Hi Jian, Sounds good to me. Leaving the CLI tools enhancement to a potential future KIP works for me.
Thanks, Andrew > On 13 Oct 2025, at 12:47, jian fu <[email protected]> wrote: > > Hi Andrew: > > Thanks for your thoughtful review and comments. > > AS1: You need to add a method `rackId()` to both MemberDescription > and ShareMemberDescription. > Jian: Add them to the KIP wiki (BTW: the PR's code already contain them). > > AS2: In the description of the ShareMemberDescription, you have > referred to it as o.a.k.clients.admin.MemberDescription. > Jian: Correct the issue. > > AS3: I wonder whether it would be worth adding rack ID support to > the --members --verbose output for both kafka-consumer-groups.sh > and kafka-share-groups.sh. Maybe you don’t want to increase the > scope of this KIP, which would be understandable, but this does > seem to finish the job. > Jian: Yes, if we also make extra change for the command-line tools, it > would definitely extend the scope. Actually, IMHO, the API should have > broader usage than tools since most companies don’t allow direct login to > machines for command execution. So I think we can focus on the current > change for now. If, in the future, someone wants to use this information > via a command, we can add that later. > > Regards > Jian > > Andrew Schofield <[email protected]> 于2025年10月13日周一 17:11写道： > >> Hi Jian, >> Thanks for the KIP. Looks like a worthwhile improvement. >> >> AS1: You need to add a method `rackId()` to both MemberDescription >> and ShareMemberDescription. >> >> AS2: In the description of the ShareMemberDescription, you have >> referred to it as o.a.k.clients.admin.MemberDescription. >> >> AS3: I wonder whether it would be worth adding rack ID support to >> the --members --verbose output for both kafka-consumer-groups.sh >> and kafka-share-groups.sh. Maybe you don’t want to increase the >> scope of this KIP, which would be understandable, but this does >> seem to finish the job. >> >> >> Thanks, >> Andrew >> >>> On 13 Oct 2025, at 03:59, jian fu <[email protected]> wrote: >>> >>> Hi all, >>> I’d like to start the discussion thread for KIP-1227: Expose Rack ID in >>> MemberDescription and ShareMemberDescription. >>> The KIP link: >>> >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1227%3A+Expose+Rack+ID+in+MemberDescription+and+ShareMemberDescription >>> >>> Currently, the ConsumerGroupDescribeResponse protocol already includes a >>> rackId field, but the Java AdminClient’s MemberDescription does not >> expose >>> it. This makes it difficult for users and monitoring tools to inspect or >>> visualize consumer group members’ rack distribution. Similarly, >>> ShareMemberDescription does not currently expose this information. >>> This KIP proposes adding an optional rackId field to both >> MemberDescription >>> and ShareMemberDescription, ensuring the Admin API reflects the rack >>> information already available in the protocol. It will improve >>> observability, help analyze rack-aware distribution, and bring better >>> consistency with other APIs (like Streams’ group descriptions). >>> >>> Please share your feedback or concerns! >>> Thanks! >>> >>> Jian >> >>
