Hi, When implementing this feature we had to make a few changes to the KIP that was voted. I have updated the KIP to match the implementation. Here is a quick summary of the changes:
1) Don't include cordoned log dirs in BrokerRegistrationRequest. This request is sent at broker startup and at that point the broker may not have the full metadata. To avoid sending invalid values that may overwrite dynamic updates, we decided to not add a new field to BrokerRegistrationRequest 2) Only send cordoned log dirs in BrokerHeartbeatRequest once fully caught up Same idea as 1), cordoned log dirs are only sent once the broker has caught up with the metadata. This ensures the latest cordoned.log.dirs value, including dynamic updates, is computed before it is sent to the controllers. 3) Limit cordoned.log.dirs changes allowed when using bootstrap controllers Brokers validate that cordoned.log.dirs are existing log.dirs. Configuration changes can also be sent to controllers directly, however they don't have the log dirs paths. Controllers only have directory ids. For that reason, controllers only allow removing entries in cordoned.log.dirs. Thanks, Mickael On Wed, Oct 8, 2025 at 6:16 PM Mickael Maison <[email protected]> wrote: > > Hi, > > I'm closing this vote. The vote has passed with > - 3 +1 binding votes from Luke, Christo and PoAn > - 1 +1 non binding vote from Federico > > Thanks, > Mickael > > On Mon, Oct 6, 2025 at 4:25 PM PoAn Yang <[email protected]> wrote: > > > > Hi, > > > > +1 (binding). Thanks for the KIP. > > > > Best, > > PoAn > > > > > On Oct 6, 2025, at 9:00 PM, Mickael Maison <[email protected]> > > > wrote: > > > > > > Hi, > > > > > > Bumping this thread again. We're still missing 1 binding vote. > > > > > > Thanks, > > > Mickael > > > > > > On Thu, Sep 25, 2025 at 6:09 AM Christo Lolov <[email protected]> > > > wrote: > > >> > > >> Hello, > > >> > > >> +1 (binding) from me! > > >> > > >> Best, > > >> Christo > > >> > > >>> On 24 Sep 2025, at 22:24, Mickael Maison <[email protected]> > > >>> wrote: > > >>> > > >>> Hi, > > >>> > > >>> Bumping the thread once more. > > >>> Let me know if you have any feedback. > > >>> > > >>> Thanks, > > >>> Mickael > > >>> > > >>>> On Thu, Aug 28, 2025 at 9:36 PM Mickael Maison > > >>>> <[email protected]> wrote: > > >>>> > > >>>> Hi, > > >>>> > > >>>> Bumping this thread, as I've addressed all the feedback in the DISCUSS > > >>>> thread. > > >>>> > > >>>> Thanks, > > >>>> Mickael > > >>>> > > >>>>> On Wed, Jul 16, 2025 at 4:44 PM Federico Valeri > > >>>>> <[email protected]> wrote: > > >>>>> > > >>>>> +1 non binding > > >>>>> > > >>>>> Thanks > > >>>>> Fede > > >>>>> > > >>>>> On Wed, Jul 9, 2025 at 8:58 AM Luke Chen <[email protected]> wrote: > > >>>>>> > > >>>>>> Re-read the KIP after 1 year, LGTM! :) > > >>>>>> > > >>>>>> +1 from me. > > >>>>>> > > >>>>>> Thanks. > > >>>>>> Luke > > >>>>>> > > >>>>>> On Tue, Jul 1, 2025 at 11:32 PM Mickael Maison > > >>>>>> <[email protected]> > > >>>>>> wrote: > > >>>>>> > > >>>>>>> Hi, > > >>>>>>> > > >>>>>>> I've not seen new comments in the DISCUSS thread in a while so I'm > > >>>>>>> starting a vote on KIP-1066 > > >>>>>>> > > >>>>>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1066%3A+Mechanism+to+cordon+brokers+and+log+directories > > >>>>>>> > > >>>>>>> Let me know if you have any feedback. > > >>>>>>> > > >>>>>>> Thanks, > > >>>>>>> Mickael > > >>>>>>> > >
