muralibasani commented on PR #856:
URL: https://github.com/apache/kafka-site/pull/856#issuecomment-4382232473

   > Thanks for picking this up.
   > 
   > I guess I should put some thoughts in the Jira when opening it. While your 
PR resolve the duplication, I'm not sure it's the approach we should take to 
resolve this. When we generate docs for a release, the `generated` folder is 
there alongside `apis`, `configurations`, etc. This is why it was there under 
42.
   > 
   > I wonder if the website should pick `generated` from that location instead 
of `static`.
   
   @mimaison pls let me know if the below approach is better to handle this 
situation. 
   
   Currently there are a few empty files in content/en/42/generated too.
   We can move files from static/42/generated to content/en/42/generated. (With 
this, generated dir will be deleted from static)
   A mount config change in hugo.yml /42/generated/ pointing to 
content/en/42/generated/. This will keep the connect_rest.yaml downloadable 
file url as is.
   include-html (shortcode) also to be pointed to new content location and 
fallback to static/<v>/generated/ so versions prior to 4.2 keep working as well.
   
   Finally update the release playbook, so for 4.3 onwards, we can keep the 
generated/ with the docs. We don't have to copy it to the static folder.
   With this, there are no URL changes and everything works the same way. 
Pages, downloads, urls, etc
   
   I tested this locally and it works.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to