Hi kafka-dev,

I wanted to start a discussion on KIP-1369.

KIP: https://cwiki.apache.org/confluence/x/Z4U_Gg

I noticed there’s already an outstanding request since 2019 
(https://issues.apache.org/jira/browse/KAFKA-9234).

I ran into a couple of cases during PRs where I missed nullity checks and was 
caught by atomic field updates. Having documented annotations on both public 
and internal classes will help catch these issues at build time rather than 
later.

In the KIP I’ve proposed we use the SpotBugs/JSR305 CLASS-retained annotations 
rather than create our custom ones - integrating custom annos for concurrency 
is an uphill battle with existing static analysis tools. Nonnull ones are 
recognised ootb if the class names are standard.

Lmk if this would be helpful to the project.

Thanks,
Aditya

Reply via email to