[ https://issues.apache.org/jira/browse/KAFKA-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14159758#comment-14159758 ]
Jun Rao commented on KAFKA-1644: -------------------------------- Alexey, My only concern of the patch is that it gives people the impression that FetchResponse.writeTo() is supported in the same way as other requests/responses by serializing the full request/response into a ByteBuffer. which can be misleading. > Inherit FetchResponse from RequestOrResponse > -------------------------------------------- > > Key: KAFKA-1644 > URL: https://issues.apache.org/jira/browse/KAFKA-1644 > Project: Kafka > Issue Type: Improvement > Reporter: Anton Karamanov > Assignee: Anton Karamanov > Attachments: > 0001-KAFKA-1644-Inherit-FetchResponse-from-RequestOrRespo.patch > > > Unlike all other Kafka API responses {{FetchResponse}} is not a subclass of > RequestOrResponse, which requires handling it as a special case while > processing responses. -- This message was sent by Atlassian JIRA (v6.3.4#6332)