> On Oct. 7, 2014, 9:06 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/consumer/PartitionAssignor.scala, line 76 > > <https://reviews.apache.org/r/26291/diff/2/?file=713892#file713892line76> > > > > Did you mean to return this?
yes. I did not want to change the return type. If there are no topics the map will be empty > On Oct. 7, 2014, 9:06 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala, line > > 655 > > <https://reviews.apache.org/r/26291/diff/2/?file=713893#file713893line655> > > > > I don't think this is required. (Or if it is can you explain?) If there are no topics the map is empty and we can just return back as there is nothing to rebalance. - Mayuresh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26291/#review55702 ----------------------------------------------------------- On Oct. 9, 2014, 12:29 a.m., Mayuresh Gharat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26291/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2014, 12:29 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1648 > https://issues.apache.org/jira/browse/KAFKA-1648 > > > Repository: kafka > > > Description > ------- > > Removed the unnecessary comment > > > Made a change to the way the condition for no topics is checked > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/PartitionAssignor.scala > 8ea7368dc394a497164ea093ff8e9f2e6a94b1de > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala > fbc680fde21b02f11285a4f4b442987356abd17b > > Diff: https://reviews.apache.org/r/26291/diff/ > > > Testing > ------- > > > Thanks, > > Mayuresh Gharat > >
