[ 
https://issues.apache.org/jira/browse/KAFKA-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14165296#comment-14165296
 ] 

Sriharsha Chintalapani commented on KAFKA-1681:
-----------------------------------------------

[~nehanarkhede] can you clarify bit on "In short, the previous code was right " 
. You mean code before KAFKA-1663. 
That code only waits till the thread starts running since the condition is
while(!deleteTopicsThread.isRunning.get() && 
!deleteTopicStateChanged.compareAndSet(true, false)) {
once thread starts and if there is resumeTopicsThread() invoked thread never 
waits because "!deleteTopicsThread.isRunning.get()". This causes a problem when 
deleteTopicsThread.shudown() is called . I believe the intention is to wait for 
notifications on delete topics and resume thread. With the above condition it 
won't wait and keeps running. 

> Newly elected KafkaController might not start deletion of pending topics
> ------------------------------------------------------------------------
>
>                 Key: KAFKA-1681
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1681
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Sriharsha Chintalapani
>            Priority: Blocker
>             Fix For: 0.8.2
>
>
> As part of KAFKA-1663 deleteTopicStateChanged.set(true) is removed from 
> start(). This will cause newly elected kafka controller not to process the 
> existing delete topic requests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to