----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26566/ -----------------------------------------------------------
Review request for kafka. Bugs: KAFKA-1680 https://issues.apache.org/jira/browse/KAFKA-1680 Repository: kafka Description ------- KAFKA-1680 Standardize command line argument parsing and usage messages. At it's heart, this was just a test of args.length that was invalid for this command, but 6b0ae4bba0d introduced the same potential issue across all the command line tools. This standardizes all the command line tools on a cleaner parsing pattern by pushing most of the work into CommandLineUtils and printing usage info for any type of parsing exception. Ideally the long term solution would be to use a newer version of joptsimple that allows us to express constraints on arguments to get almost all command line option issues resolved at parse time. Diffs ----- core/src/main/scala/kafka/admin/PreferredReplicaLeaderElectionCommand.scala c7918483c02040a7cc18d6e9edbd20a3025a3a55 core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 691d69a49a240f38883d2025afaec26fd61281b5 core/src/main/scala/kafka/admin/TopicCommand.scala 7672c5aab4fba8c23b1bb5cd4785c332d300a3fa core/src/main/scala/kafka/tools/ConsoleConsumer.scala 323fc8566d974acc4e5c7d7c2a065794f3b5df4a core/src/main/scala/kafka/tools/ConsoleProducer.scala 8e9ba0b284671989f87d9c421bc98f5c4384c260 core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala d1e7c434e77859d746b8dc68dd5d5a3740425e79 core/src/main/scala/kafka/tools/ConsumerPerformance.scala 093c800ea7f8a9c972bb66e99ac4e4d431cf11cc core/src/main/scala/kafka/tools/DumpLogSegments.scala 8e9d47b8d4adc5754ed8861aa04ddd3c6b629e3d core/src/main/scala/kafka/tools/ExportZkOffsets.scala 4d051bc2db12f0e15aa6a3289abeb9dd25d373d2 core/src/main/scala/kafka/tools/GetOffsetShell.scala 3d9293e4abbe3f4a4a2bc5833385747c604d5a95 core/src/main/scala/kafka/tools/ImportZkOffsets.scala abe09721b13f71320510fd1a01c1917470450c6e core/src/main/scala/kafka/tools/JmxTool.scala 1d1a120c45ff70fbd60df5b147ca230eb1ef50de core/src/main/scala/kafka/tools/MirrorMaker.scala b8698ee1469c8fbc92ccc176d916eb3e28b87867 core/src/main/scala/kafka/tools/ProducerPerformance.scala f61c7c701fd85caabc2d2950a7b02aa85e5cdfe3 core/src/main/scala/kafka/tools/ReplayLogProducer.scala 3393a3dd574ac45a27bf7eda646b737146c55038 core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala ba6ddd7a909df79a0f7d45e8b4a2af94ea0fceb6 core/src/main/scala/kafka/tools/SimpleConsumerPerformance.scala 7602b8d705970a5dab49ed36d117346a960701ac core/src/main/scala/kafka/tools/SimpleConsumerShell.scala b4f903b6c7c3bb725cac7c05eb1f885906413c4d core/src/main/scala/kafka/tools/StateChangeLogMerger.scala d298e7e81acc7427c6cf4796b445966267ca54eb core/src/main/scala/kafka/tools/TestLogCleaning.scala 1d4ea93f2ba8d4d4d47a307cd47f54a15d3d30dd core/src/main/scala/kafka/tools/VerifyConsumerRebalance.scala aef8361b73a0934641fc4f5cee942b5b50f3e7d7 core/src/main/scala/kafka/utils/CommandLineUtils.scala 086a62483fad0c9cfc7004ff94c890cfb9929fa6 core/src/main/scala/kafka/utils/ToolsUtils.scala fef93929ea03e181f87fe294c06d9bc9fc823e9e core/src/test/scala/other/kafka/TestLinearWriteSpeed.scala 7211c2529c1db76100432737da7a1d1d221dfba0 Diff: https://reviews.apache.org/r/26566/diff/ Testing ------- Thanks, Ewen Cheslack-Postava