[ https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14171082#comment-14171082 ]
James Oliver commented on KAFKA-1493: ------------------------------------- Sorry to not be more clear - I fixed a few spots related to the removal of the LZ4HC option, but left the I/O streams in Ivan's patch alone. Since I didn't have permissions to update Ivan's reviewboard, I created a new review. 1. This looks like Ivan's interpretation of the lz4-java block stream format. 2. We should use neither - the lz4-java impl was used previously (KAFKA-1456). Review by the community produced this issue. We need a real implementation of http://fastcompression.blogspot.com/2013/04/lz4-streaming-format-final.html > Use a well-documented LZ4 compression format and remove redundant LZ4HC option > ------------------------------------------------------------------------------ > > Key: KAFKA-1493 > URL: https://issues.apache.org/jira/browse/KAFKA-1493 > Project: Kafka > Issue Type: Improvement > Affects Versions: 0.8.2 > Reporter: James Oliver > Assignee: Ivan Lyutov > Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1493.patch, KAFKA-1493.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)