[
https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14178039#comment-14178039
]
Vladimir Tretyakov commented on KAFKA-1481:
-------------------------------------------
Hi, added last patch (KAFKA-1481_2014-10-21_09-14-35.patch). Worked for me
locally (previous worked too:( ).
There are commands I've used:
{code}
PATCH CREATION
wawanawna@wawanawna:/home/storage/sematext/src/kfk2/kafka$ git status
On branch 0.8.2
Your branch is up-to-date with 'origin/0.8.2'.
Changes to be committed:
(use "git reset HEAD <file>..." to unstage)
new file: core/src/main/scala/kafka/common/BrokerInfo.scala
new file: core/src/main/scala/kafka/common/ClientIdTopic.scala
new file: core/src/main/scala/kafka/common/Taggable.scala
renamed: core/src/main/scala/kafka/common/ClientIdAndTopic.scala ->
core/src/main/scala/kafka/common/TopicInfo.scala
new file:
core/src/main/scala/kafka/consumer/ConsumerFetcherThreadId.scala
new file: core/src/main/scala/kafka/consumer/ConsumerId.scala
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git checkout -- <file>..." to discard changes in working directory)
modified: core/src/main/scala/kafka/admin/AdminUtils.scala
modified:
core/src/main/scala/kafka/api/HeartbeatRequestAndHeader.scala
modified:
core/src/main/scala/kafka/api/HeartbeatResponseAndHeader.scala
modified:
core/src/main/scala/kafka/api/JoinGroupRequestAndHeader.scala
modified:
core/src/main/scala/kafka/api/JoinGroupResponseAndHeader.scala
modified: core/src/main/scala/kafka/api/RequestKeys.scala
modified: core/src/main/scala/kafka/cluster/Partition.scala
...
...
...
wawanawna@wawanawna:/home/storage/sematext/src/kfk2/kafka$ git commit -a -m
'kafka-1481; JMX renaming'
[0.8.2 a232af6] kafka-1481; JMX renaming
73 files changed, 666 insertions(+), 435 deletions(-)
create mode 100644 core/src/main/scala/kafka/common/BrokerInfo.scala
create mode 100644 core/src/main/scala/kafka/common/ClientIdTopic.scala
create mode 100644 core/src/main/scala/kafka/common/Taggable.scala
rename core/src/main/scala/kafka/common/{ClientIdAndTopic.scala =>
TopicInfo.scala} (68%)
create mode 100644
core/src/main/scala/kafka/consumer/ConsumerFetcherThreadId.scala
create mode 100644 core/src/main/scala/kafka/consumer/ConsumerId.scala
wawanawna@wawanawna:/home/storage/sematext/src/kfk2/kafka$ git log | head -n 20
commit a232af63b8a1f43054994a74520b31ef7b9b347c
Author: wawanawna <[email protected]>
Date: Tue Oct 21 09:29:31 2014 +0300
kafka-1481; JMX renaming
commit eb7ac9eb7eebc4e0655b65e07cae594e61a6c05e
Author: Jun Rao <[email protected]>
Date: Mon Oct 20 11:09:31 2014 -0700
kafka-1717; remove netty dependency through ZK 3.4.x; patched by Jun Rao;
reviewed by Sriharsha Chintalapani and Neha Narkhede
wawanawna@wawanawna:/home/storage/sematext/src/kfk2/kafka$ git diff
eb7ac9eb7eebc4e0655b65e07cae594e61a6c05e
a232af63b8a1f43054994a74520b31ef7b9b347c >
/tmp/KAFKA-1481_2014-10-21_09-14-35.patch
PATCH APPLYING
wawanawna@wawanawna$ git clone https://github.com/apache/kafka.git
wawanawna@wawanawna:/home/storage/sematext/src/kfk3/kafka$ git checkout -b
0.8.2 origin/0.8.2
Branch 0.8.2 set up to track remote branch 0.8.2 from origin.
Switched to a new branch '0.8.2'
wawanawna@wawanawna:/home/storage/sematext/src/kfk3/kafka$ git apply
/tmp/KAFKA-1481_2014-10-21_09-14-35.patch
/tmp/KAFKA-1481_2014-10-21_09-14-35.patch:1410: trailing whitespace.
})
warning: 1 line adds whitespace errors.
{code}
There is warning, but everything works (compilation/tests passed without errors)
PS: please tell me what I am doing wrong.
wawanawna@wawanawna:/home/storage/sematext/src/kfk3/kafka$ git --version
git version 1.9.1
> Stop using dashes AND underscores as separators in MBean names
> --------------------------------------------------------------
>
> Key: KAFKA-1481
> URL: https://issues.apache.org/jira/browse/KAFKA-1481
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8.1.1
> Reporter: Otis Gospodnetic
> Priority: Critical
> Labels: patch
> Fix For: 0.8.2
>
> Attachments: KAFKA-1481_2014-06-06_13-06-35.patch,
> KAFKA-1481_2014-10-13_18-23-35.patch, KAFKA-1481_2014-10-14_21-53-35.patch,
> KAFKA-1481_2014-10-15_10-23-35.patch, KAFKA-1481_2014-10-20_23-14-35.patch,
> KAFKA-1481_2014-10-21_09-14-35.patch,
> KAFKA-1481_IDEA_IDE_2014-10-14_21-53-35.patch,
> KAFKA-1481_IDEA_IDE_2014-10-15_10-23-35.patch,
> KAFKA-1481_IDEA_IDE_2014-10-20_20-14-35.patch,
> KAFKA-1481_IDEA_IDE_2014-10-20_23-14-35.patch
>
>
> MBeans should not use dashes or underscores as separators because these
> characters are allowed in hostnames, topics, group and consumer IDs, etc.,
> and these are embedded in MBeans names making it impossible to parse out
> individual bits from MBeans.
> Perhaps a pipe character should be used to avoid the conflict.
> This looks like a major blocker because it means nobody can write Kafka 0.8.x
> monitoring tools unless they are doing it for themselves AND do not use
> dashes AND do not use underscores.
> See: http://search-hadoop.com/m/4TaT4lonIW
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
