Thanks for the reminder. I can take a look at the patch. Joel
On Tue, Oct 21, 2014 at 01:40:27PM -0400, Gwen Shapira wrote: > Note that I added a patch with 0.8.2 documentation to KAFKA-1555 (in > order to document the new min.isr behavior). > > We need to get this committed in SVN before the release, and probably > document few more things (new producer for example). > > Gwen > > On Tue, Oct 21, 2014 at 12:07 PM, Jun Rao <jun...@gmail.com> wrote: > > KAFKA-1583 will only be in trunk. It would be nice if we fix KAFKA-1634 in > > 0.8.2 too (may need a separate patch). If we can get a patch ready, we can > > include it in 0.8.2 final. > > > > Thanks, > > > > Jun > > > > On Tue, Oct 21, 2014 at 8:00 AM, Joel Koshy <jjkosh...@gmail.com> wrote: > > > >> KAFKA-1634 is orthogonal to 1583 right? (BTW sorry about the delay in > >> reviewing 1583 - I'm on it.) > >> > >> KAFKA-1634 shouldn't be too difficult to address so I'm hoping we can > >> get that in 0.8.2 if not the beta release. > >> > >> Joel > >> > >> On Mon, Oct 20, 2014 at 09:14:17PM -0700, Jun Rao wrote: > >> > I move KAFKA-1634 to 0.8.3 since it's easier to fix after KAFKA-1583 is > >> > committed. With this, we have resolved all known blocker issues for > >> 0.8.2. > >> > Thanks everyone. > >> > > >> > Joe, > >> > > >> > Do you want to help start rolling an 0.8.2 beta release? We can decide if > >> > we need to include any other fixes (e.g., KAFKA-1481) in the 0.8.2 final > >> > release. > >> > > >> > Thanks, > >> > > >> > Jun > >> > > >> > On Thu, Oct 16, 2014 at 3:53 PM, Joel Koshy <jjkosh...@gmail.com> wrote: > >> > > >> > > +1 on the beta. I think KAFKA-1583 should only be on trunk, not 0.8.2 > >> > > so that will only go out with 0.8.3. > >> > > > >> > > Joel > >> > > > >> > > On Thu, Oct 16, 2014 at 03:25:39PM -0700, Guozhang Wang wrote: > >> > > > Agree. > >> > > > On Oct 16, 2014 3:16 PM, "Jun Rao" <jun...@gmail.com> wrote: > >> > > > > >> > > > > +1 on doing an 0.8.2 beta. > >> > > > > > >> > > > > Guozhang, > >> > > > > > >> > > > > kafka-1583 is relatively large. Given that we are getting close to > >> > > > > releasing 0.8.2 beta, my feeling is that we probably shouldn't > >> include > >> > > it > >> > > > > in 0.8.2 beta even if we can commit it in a few days. > >> > > > > > >> > > > > Thanks, > >> > > > > > >> > > > > Jun > >> > > > > > >> > > > > On Thu, Oct 16, 2014 at 3:01 PM, Guozhang Wang <wangg...@gmail.com > >> > > >> > > wrote: > >> > > > > > >> > > > > > Regarding 1634, I was intended to work on that after 1583 since > >> it > >> > > will > >> > > > > > changes the commit offset request handling logic a lot. If people > >> > > think > >> > > > > > 1583 is only a few days away before check-in, we can leave in in > >> > > > > > 0.8.2-beta; otherwise we can push to 0.8.3. > >> > > > > > > >> > > > > > Guozhang > >> > > > > > > >> > > > > > On Thu, Oct 16, 2014 at 2:19 PM, Joe Stein <joe.st...@stealth.ly > >> > > >> > > wrote: > >> > > > > > > >> > > > > > > +1 for a 0.8.2-beta next week and 0.8.2.0 final 4-5 weeks > >> later. > >> > > > > > > > >> > > > > > > I agree to the tickets you brought up to have in 0.8.2-beta and > >> > > also > >> > > > > > > https://issues.apache.org/jira/browse/KAFKA-1493 for lz4 > >> > > compression. > >> > > > > > > > >> > > > > > > /******************************************* > >> > > > > > > Joe Stein > >> > > > > > > Founder, Principal Consultant > >> > > > > > > Big Data Open Source Security LLC > >> > > > > > > http://www.stealth.ly > >> > > > > > > Twitter: @allthingshadoop > >> > > > > > > ********************************************/ > >> > > > > > > On Oct 16, 2014 12:55 PM, "Neha Narkhede" < > >> neha.narkh...@gmail.com > >> > > > > >> > > > > > wrote: > >> > > > > > > > >> > > > > > > > Another JIRA that will be nice to include as part of > >> 0.8.2-beta > >> > > is > >> > > > > > > > https://issues.apache.org/jira/browse/KAFKA-1481 that fixes > >> the > >> > > > > mbean > >> > > > > > > > naming. Looking for people's thoughts on 2 things here - > >> > > > > > > > > >> > > > > > > > 1. How do folks feel about doing a 0.8.2-beta release right > >> now > >> > > and > >> > > > > > 0.8.2 > >> > > > > > > > final 4-5 weeks later? > >> > > > > > > > 2. Do people want to include any JIRAs (other than the ones > >> > > mentioned > >> > > > > > > > above) in 0.8.2-beta? If so, it will be great to know now so > >> it > >> > > will > >> > > > > > > allow > >> > > > > > > > us to move forward with the beta release quickly. > >> > > > > > > > > >> > > > > > > > Thanks, > >> > > > > > > > Neha > >> > > > > > > > > >> > > > > > > > On Wed, Oct 15, 2014 at 4:46 PM, Neha Narkhede < > >> > > > > > neha.narkh...@gmail.com> > >> > > > > > > > wrote: > >> > > > > > > > > >> > > > > > > > > Hi, > >> > > > > > > > > > >> > > > > > > > > We have accumulated an impressive list of pretty major > >> > > features in > >> > > > > > > 0.8.2 > >> > > > > > > > - > >> > > > > > > > > Delete topic > >> > > > > > > > > Automated leader rebalancing > >> > > > > > > > > Controlled shutdown > >> > > > > > > > > Offset management > >> > > > > > > > > Parallel recovery > >> > > > > > > > > min.isr and > >> > > > > > > > > clean leader election > >> > > > > > > > > > >> > > > > > > > > In the past, what has worked for major feature releases is > >> a > >> > > beta > >> > > > > > > release > >> > > > > > > > > prior to a final release. I'm proposing we do the same for > >> > > 0.8.2. > >> > > > > The > >> > > > > > > > only > >> > > > > > > > > blockers for 0.8.2-beta, that I know of are - > >> > > > > > > > > > >> > > > > > > > > https://issues.apache.org/jira/browse/KAFKA-1493 (Is a > >> major > >> > > > > change > >> > > > > > > and > >> > > > > > > > > requires some thinking about the new dependency. Since it > >> is > >> > > not > >> > > > > > fully > >> > > > > > > > > ready and there are things to think about, I suggest we > >> take it > >> > > > > out, > >> > > > > > > > think > >> > > > > > > > > it end to end and then include it in 0.8.3.) > >> > > > > > > > > https://issues.apache.org/jira/browse/KAFKA-1634 (This > >> has an > >> > > > > owner: > >> > > > > > > > > Guozhang Wang) > >> > > > > > > > > https://issues.apache.org/jira/browse/KAFKA-1671 (Has a > >> patch > >> > > and > >> > > > > is > >> > > > > > > > > waiting on a review by Joe Stein) > >> > > > > > > > > > >> > > > > > > > > It seems that 1634 and 1671 can get wrapped up in a week. > >> Do > >> > > people > >> > > > > > > think > >> > > > > > > > > we should cut 0.8.2-beta by next week? > >> > > > > > > > > > >> > > > > > > > > Thanks, > >> > > > > > > > > Neha > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > -- > >> > > > > > -- Guozhang > >> > > > > > > >> > > > > > >> > > > >> > > > >> > >>
