----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26994/#review57680 -----------------------------------------------------------
core/src/main/scala/kafka/tools/MirrorMaker.scala <https://reviews.apache.org/r/26994/#comment98497> Just a stylish comment: could you group java imports with scala / other lib imports, and leave kafka imports at the top? core/src/main/scala/kafka/tools/MirrorMaker.scala <https://reviews.apache.org/r/26994/#comment98503> Can we add a FATAL log entry here: "Consumer thread existed abnormally, stopping the whole mirror maker"? core/src/main/scala/kafka/tools/MirrorMaker.scala <https://reviews.apache.org/r/26994/#comment98501> Ditto above. core/src/main/scala/kafka/tools/MirrorMaker.scala <https://reviews.apache.org/r/26994/#comment98499> Is this change intended? - Guozhang Wang On Oct. 21, 2014, 8:37 p.m., Jiangjie Qin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26994/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2014, 8:37 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1719 > https://issues.apache.org/jira/browse/KAFKA-1719 > > > Repository: kafka > > > Description > ------- > > make mirror maker exit when one consumer/producer thread exits. > > > Diffs > ----- > > core/src/main/scala/kafka/tools/MirrorMaker.scala > b8698ee1469c8fbc92ccc176d916eb3e28b87867 > > Diff: https://reviews.apache.org/r/26994/diff/ > > > Testing > ------- > > > Thanks, > > Jiangjie Qin > >
