Yes, this is actually indeed an incompatible change. In 0.8.1.x, ConsumerConnector has the following api: def commitOffsets
This is changed to the following in 0.8.2 and breaks compatibility def commitOffsets(retryOnFailure: Boolean = true) Filed KAFKA-1743 as an 0.8.2 blocker. Thanks, Jun On Fri, Oct 31, 2014 at 3:07 PM, Jack Foy <j...@whitepages.com> wrote: > On Thu, Oct 30, 2014 at 9:20 AM, Jay Kreps <jay.kr...@gmail.com<mailto: > jay.kr...@gmail.com>> wrote: > I think we should treat this like a bug for 0.8.2 final, we should be able > to add two commitOffsets methods with and without the param which should > fix the problem, right? > > On Oct 30, 2014, at 9:51 AM, Jun Rao <jun...@gmail.com<mailto: > jun...@gmail.com>> wrote: > Yes, we can change this to two methods in 0.8.2 final. > > Thanks. After some experimentation, I think there isn’t actually a form of > this code that can compile under both kafka 0.8.1.1 and 0.8.2-beta. > > This form fails to compile against kafka-0.8.1.1: connector.commitOffsets() > > [error] > src/main/scala/com/whitepages/kafka/consumer/Connector.scala:21: Unit does > not take parameters > [error] connector.commitOffsets() > [error] ^ > > This form fails to compile against kafka-0.8.2-beta: > connector.commitOffsets > > [error] > src/main/scala/com/whitepages/kafka/consumer/Connector.scala:21: missing > arguments for method commitOffsets in trait ConsumerConnector; > [error] follow this method with `_' if you want to treat it as a > partially applied function > [error] connector.commitOffsets > [error] ^ > > -- > Jack Foy <j...@whitepages.com<mailto:j...@whitepages.com>> > > > >
