[
https://issues.apache.org/jira/browse/KAFKA-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14194983#comment-14194983
]
Ewen Cheslack-Postava commented on KAFKA-1746:
----------------------------------------------
Created reviewboard https://reviews.apache.org/r/27534/diff/
against branch origin/trunk
> System tests don't handle errors well
> -------------------------------------
>
> Key: KAFKA-1746
> URL: https://issues.apache.org/jira/browse/KAFKA-1746
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8.1.1
> Reporter: Ewen Cheslack-Postava
> Attachments: KAFKA-1746.patch
>
>
> The system test scripts don't handle errors well. A couple of key issues:
> * Unexpected exceptions during tests are just ignored and the tests appear to
> be successful in the reports.
> * The scripts exit code is always 0, even if tests fail.
> * Almost no subprocess calls are checked. In a lot of cases this is ok, and
> sometimes it's not possible (e.g. after starting a long-running remote
> process), but in some cases such as calls to DumpLogSegments, the tests can
> miss that the tools is exiting with an exception and the test appears to be
> successful even though no data was verified.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
