[ https://issues.apache.org/jira/browse/KAFKA-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14198670#comment-14198670 ]
Gwen Shapira commented on KAFKA-1667: ------------------------------------- I think we can do better validations. For example: .define(MinCleanableDirtyRatioProp, DOUBLE, Defaults.MinCleanableDirtyRatio, atLeast(0), MEDIUM, "") Can be: .define(MinCleanableDirtyRatioProp, DOUBLE, Defaults.MinCleanableDirtyRatio, between(0,1), MEDIUM, "") Since its a ratio. Once you have RB, I can add more detail for other configs. > topic-level configuration not validated > ---------------------------------------- > > Key: KAFKA-1667 > URL: https://issues.apache.org/jira/browse/KAFKA-1667 > Project: Kafka > Issue Type: Bug > Affects Versions: 0.8.1.1 > Reporter: Ryan Berdeen > Labels: newbie > Attachments: KAFKA-1667.patch > > > I was able to set the configuration for a topic to these invalid values: > {code} > Topic:topic-config-test PartitionCount:1 ReplicationFactor:2 > Configs:min.cleanable.dirty.ratio=-30.2,segment.bytes=-1,retention.ms=-12,cleanup.policy=lol > {code} > It seems that the values are saved as long as they are the correct type, but > are not validated like the corresponding broker-level properties. -- This message was sent by Atlassian JIRA (v6.3.4#6332)