[
https://issues.apache.org/jira/browse/KAFKA-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202955#comment-14202955
]
Joel Koshy commented on KAFKA-1742:
-----------------------------------
+1, although one minor change:
{code}
// instead of
filter(p => !p._1.topic.equals(topic)
//
filter{ case(topicPartition, _) => topicPartition.topic != topicToRemove }
{code}
I'm a bit divided on the usefulness of the unit test.
> ControllerContext removeTopic does not correctly update state
> -------------------------------------------------------------
>
> Key: KAFKA-1742
> URL: https://issues.apache.org/jira/browse/KAFKA-1742
> Project: Kafka
> Issue Type: Bug
> Reporter: Onur Karaman
> Assignee: Onur Karaman
> Priority: Blocker
> Fix For: 0.8.2
>
> Attachments: KAFKA-1742.patch
>
>
> removeTopic does not correctly update the state of ControllerContext.
> This is because it removes the topic from some underlying maps through
> dropWhile.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
