Re: Review Request 27834: Fix KAFKA-1762: add comment on risks using a larger value of max.inflight.requests than 1, in KAFKA-1650 we will add another comment about its risk of data loss

[Joel Koshy]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27834/#review61123
-----------------------------------------------------------

Ship it!



clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
<https://reviews.apache.org/r/27834/#comment102598>

    I would actually prefer not mentioning the "default value" comment - (say, 
if we change the default ever).


- Joel Koshy


On Nov. 10, 2014, 10:53 p.m., Guozhang Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27834/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2014, 10:53 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1762
>     https://issues.apache.org/jira/browse/KAFKA-1762
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> dummy
> 
> 
> Diffs
> -----
> 
>   clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java 
> 9095caf0db1e41a4acb4216fb197626fbd85b806 
> 
> Diff: https://reviews.apache.org/r/27834/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guozhang Wang
> 
>