[ 
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14209071#comment-14209071
 ] 

Jun Rao commented on KAFKA-1729:
--------------------------------

Thanks for the patch. A few comments.

1. We need to make sure that before people start using the Kafka-based offset 
management in production, they set offsets.topic.num.partitions and 
offsets.topic.replication.factor properly for the offset topic since the 
defaults are not suitable for production usage. Could you add that in 
implementation.html? 

2. It seems that issuing manual OffsetCommitRequest is only needed when using 
SimpleConsumer. We can probably make that clear in the wiki.

> add doc for Kafka-based offset management in 0.8.2
> --------------------------------------------------
>
>                 Key: KAFKA-1729
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1729
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: Jun Rao
>            Assignee: Joel Koshy
>         Attachments: KAFKA-1782-doc-v1.patch, KAFKA-1782-doc-v2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to