----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27693/#review61515 -----------------------------------------------------------
core/src/main/scala/kafka/tools/ConsumerCommand.scala <https://reviews.apache.org/r/27693/#comment103194> This patch still doesn't address the issues I pointed out in my previous review. We should expose configs through a generic config option that takes in key value pairs. Let's remove both of these and replace it with --config. core/src/main/scala/kafka/tools/ConsumerCommand.scala <https://reviews.apache.org/r/27693/#comment103196> describe-group should work independently of topic. In that case it should describe for all topics that the group is subscribed to. core/src/main/scala/kafka/tools/ConsumerCommand.scala <https://reviews.apache.org/r/27693/#comment103199> List->Seq core/src/main/scala/kafka/tools/ConsumerCommand.scala <https://reviews.apache.org/r/27693/#comment103198> Let's use CSV instead of spaces. That way the output is scriptable. core/src/main/scala/kafka/tools/ConsumerCommand.scala <https://reviews.apache.org/r/27693/#comment103200> remove toList. - Neha Narkhede On Nov. 10, 2014, 7:06 p.m., Balaji Seshadri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27693/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2014, 7:06 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1476 > https://issues.apache.org/jira/browse/KAFKA-1476 > > > Repository: kafka > > > Description > ------- > > KAFKA-1476 Get list of consumer groups - Review Comments > > > Diffs > ----- > > core/src/main/scala/kafka/tools/ConsumerCommand.scala PRE-CREATION > core/src/main/scala/kafka/utils/ZkUtils.scala > 56e3e88e0cc6d917b0ffd1254e173295c1c4aabd > > Diff: https://reviews.apache.org/r/27693/diff/ > > > Testing > ------- > > > Thanks, > > Balaji Seshadri > >
