----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27990/#review61855 -----------------------------------------------------------
Ship it! Looks good! Two minor readability comments from my side, and a non-binding +1. core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala <https://reviews.apache.org/r/27990/#comment103764> I still think its pretty difficult to tell here that entry._2 refers to replicas. core/src/test/scala/unit/kafka/admin/AdminTest.scala <https://reviews.apache.org/r/27990/#comment103766> Maybe comment on why you want to fail here. Unlike assertions, these tests are not self documenting. - Gwen Shapira On Nov. 17, 2014, 2:33 p.m., Dmitry Pekar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27990/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2014, 2:33 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1751 > https://issues.apache.org/jira/browse/KAFKA-1751 > > > Repository: kafka > > > Description > ------- > > KAFKA-1751 / CR fixes > > > Diffs > ----- > > core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala > 979992b68af3723cd229845faff81c641123bb88 > core/src/test/scala/unit/kafka/admin/AdminTest.scala > e28979827110dfbbb92fe5b152e7f1cc973de400 > core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala > 29cc01bcef9cacd8dec1f5d662644fc6fe4994bc > > Diff: https://reviews.apache.org/r/27990/diff/ > > > Testing > ------- > > > Thanks, > > Dmitry Pekar > >
