GitHub user rocketraman opened a pull request:

    https://github.com/apache/kafka/pull/36

    Remove non-functional variable definition in log4j.properties

    In log4j.properties, a property kafka.logs.dir was defined. However, 
modifying this property has no effect because log4j.properties does not support 
variable substitution in this manner. Rather ${kafka.logs.dir} is looked up as 
a System property, which is set in bin/kafka-run-class.sh, and must currently 
be changed there if the log4j logging location is to be modified.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rocketraman/kafka patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/36.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #36
    
----
commit 3f0ff445d8d9e30055ca8a8b3ae8f5cf1f26f47c
Author: Raman Gupta <rocketra...@gmail.com>
Date:   2014-11-19T22:53:14Z

    Remove non-functional variable definition in log4j.properties
    
    In log4j.properties, a property kafka.logs.dir was defined. However, 
modifying this property has no effect because log4j.properties does not support 
variable substitution in this manner. Rather ${kafka.logs.dir} is looked up as 
a System property, which is set in bin/kafka-run-class.sh, and must currently 
be changed there if the log4j logging location is to be modified.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to