[ 
https://issues.apache.org/jira/browse/KAFKA-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14219794#comment-14219794
 ] 

Sriharsha Chintalapani commented on KAFKA-1070:
-----------------------------------------------

[~nehanarkhede] [~charmalloc] [~otis]
Please take a look at the latest patch. I added broker.id.policy as a 
configurable option with "ip" and "sequence" .
I've few questions regarding "ip" based broker.id.
currently the patch expects /etc/hosts to be properly configured with an ip 
associated with the hostname.
1) should we ignore loopback ip
    i) if we don't consider loopback ip than on a single node machine with 
/etc/hosts is not being configured properly it will thrown an error
   ii) if we consider this than there is a same broker id being generate on 
multiple hosts or multiple brokers on a single host ( this could be the case in 
non loopback ips too)
2) broker.id is Int and there is a  possibility of  throwing  a 
NumberFormatException if the ip doesn't fit in Int.MaxValue
3) If a host contains multiple network interfaces which ip should we pick up. 
Current implementation takes whatever configured for the hostname in /etc/hosts 
which seems ok to me . 
Please let me know your thoughts on the above. Thanks.

> Auto-assign node id
> -------------------
>
>                 Key: KAFKA-1070
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1070
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Jay Kreps
>            Assignee: Sriharsha Chintalapani
>              Labels: usability
>             Fix For: 0.8.3
>
>         Attachments: KAFKA-1070.patch, KAFKA-1070_2014-07-19_16:06:13.patch, 
> KAFKA-1070_2014-07-22_11:34:18.patch, KAFKA-1070_2014-07-24_20:58:17.patch, 
> KAFKA-1070_2014-07-24_21:05:33.patch, KAFKA-1070_2014-08-21_10:26:20.patch, 
> KAFKA-1070_2014-11-20_10:50:04.patch
>
>
> It would be nice to have Kafka brokers auto-assign node ids rather than 
> having that be a configuration. Having a configuration is irritating because 
> (1) you have to generate a custom config for each broker and (2) even though 
> it is in configuration, changing the node id can cause all kinds of bad 
> things to happen.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to