> On Nov. 22, 2014, 2:24 a.m., Joel Koshy wrote: > > Looks good, although the patch does not apply - can you rebase; check that > > it builds properly and then we can close this out. > > Guozhang Wang wrote: > This is a little wired.. both you and Gwen said it does not apply but > when I apply the patch (patch -p1 --dry-run < patch.file) it works fine. Will > verify that one last time and commit.
OK I found out the reason. It is because the rb diff command does not handle window-based "^M" well in kafka-run-class.bat, and after changing to use linux diff it works fine. - Guozhang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28268/#review62721 ----------------------------------------------------------- On Nov. 24, 2014, 7:02 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28268/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2014, 7:02 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1624 > https://issues.apache.org/jira/browse/KAFKA-1624 > > > Repository: kafka > > > Description > ------- > > KAFKA-1624.v1 > > > Diffs > ----- > > bin/kafka-run-class.sh 36c742b67a7259fa35c3ed862f7ccc4673b69d9f > bin/windows/kafka-run-class.bat 8e9780e2eb74a35a72678715cccc5c09b151d0ba > build.gradle 030af63553afbde5756ed5fd7be6d41a6e400f43 > gradle.properties 5d3155fd4461438d8b2ec4faa9534cc2383d4951 > scala.gradle 6adf9af7dbbe71e68a07b387c3854d8c9ad339e0 > > Diff: https://reviews.apache.org/r/28268/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
