----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28121/#review62926 -----------------------------------------------------------
Ship it! - Neha Narkhede On Nov. 25, 2014, 1:24 a.m., Ewen Cheslack-Postava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28121/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2014, 1:24 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1780 > https://issues.apache.org/jira/browse/KAFKA-1780 > > > Repository: kafka > > > Description > ------- > > Expand documentation on ConsumerIterator to reflect new non-blocking APIs. > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/ConsumerIterator.scala > 78fbf75651583e390258af2d9f09df6911a97b59 > core/src/main/scala/kafka/utils/IteratorTemplate.scala > fd952f3ec0f04a3ba639c02779634265489fd186 > core/src/test/scala/unit/kafka/consumer/ConsumerIteratorTest.scala > c0355cc0135c6af2e346b4715659353a31723b86 > core/src/test/scala/unit/kafka/utils/IteratorTemplateTest.scala > 46a4e899ef293c56a931bfa5bcf9a07d07ec5792 > > Diff: https://reviews.apache.org/r/28121/diff/ > > > Testing > ------- > > > Thanks, > > Ewen Cheslack-Postava > >