----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28793/#review64477 -----------------------------------------------------------
Can you add unit tests for this? core/src/main/scala/kafka/tools/OffsetClient.scala <https://reviews.apache.org/r/28793/#comment107194> This and a lot of the rest of the code exists in ClientUtils. Until the refactoring is complete, your admin tool can just utilize the existing APIst to expose commit/fetch through the tool. This class may be unnecessary. - Neha Narkhede On Dec. 7, 2014, 7:43 p.m., Mayuresh Gharat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28793/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2014, 7:43 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1784 > https://issues.apache.org/jira/browse/KAFKA-1784 > > > Repository: kafka > > > Description > ------- > > Offset Client for fetching and commiting offsets to kafka > > > Diffs > ----- > > core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION > core/src/main/scala/kafka/tools/OffsetClientConfig.scala PRE-CREATION > > Diff: https://reviews.apache.org/r/28793/diff/ > > > Testing > ------- > > > Thanks, > > Mayuresh Gharat > >
