[
https://issues.apache.org/jira/browse/KAFKA-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243741#comment-14243741
]
Gwen Shapira commented on KAFKA-1811:
-------------------------------------
Few notes that may help:
1. We like reviewing with review board. Here's a friendly instruction page on
how to add the patch to JIRA and RB at once:
https://cwiki.apache.org/confluence/display/KAFKA/Kafka+patch+review+tool
2. We also like unit tests :)
3. I'd consider pushing this check down to registerBrokerInZk. It seems like a
natural place to ensure uniqueness of registered brokers before registering.
4. Another thing to consider is race conditions - what if new broker registers
while we are checking?
Perhaps we can even use ZK itself to enforce uniqueness?
(Note: I'm not a committer, so those suggestions are not binding. just ideas
for improvements)
> ensuring registered broker host:port is unique
> ----------------------------------------------
>
> Key: KAFKA-1811
> URL: https://issues.apache.org/jira/browse/KAFKA-1811
> Project: Kafka
> Issue Type: Improvement
> Reporter: Jun Rao
> Labels: newbie
> Attachments: KAFKA_1811.patch
>
>
> Currently, we expect each of the registered broker to have a unique host:port
> pair. However, we don't enforce that, which causes various weird problems. It
> would be useful to ensure this during broker registration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
