-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25995/
-----------------------------------------------------------
(Updated Dec. 16, 2014, 4:03 p.m.)
Review request for kafka.
Bugs: KAFKA-1650 and KAKFA-1650
https://issues.apache.org/jira/browse/KAFKA-1650
https://issues.apache.org/jira/browse/KAKFA-1650
Repository: kafka
Description (updated)
-------
Addressed Guozhang's comments.
Addressed Guozhang's comments
commit before switch to trunk
commit before rebase
Rebased on trunk, Addressed Guozhang's comments.
Addressed Guozhang's comments on MaxInFlightRequests
Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into
mirrormaker-redesign
Incorporated Guozhang's comments
Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into
mirrormaker-redesign
Merged KAFKA-345 into this patch. Incorporated Joel and Jun's comments.
Added consumer rebalance listener to mirror maker, will test it later.
Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into
mirrormaker-redesign
Conflicts:
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala
core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala
added custom config for consumer rebalance listener
Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into
mirrormaker-redesign
Add configurable consumer rebalance listener
Incorporated Guozhang's comments
Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into
mirrormaker-redesign
Incorporated Guozhang's comments.
Addressed Guozhang's comment.
numMessageUnacked should be decremented no matter the send was successful or
not.
Addressed Jun's comments.
Incorporated Jun's comments
Incorporated Jun's comments and rebased on trunk
Rebased on current trunk
Diffs (updated)
-----
core/src/main/scala/kafka/consumer/ConsumerConnector.scala
62c0686e816d2888772d5a911becf625eedee397
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala
e991d2187d03241f639eeaf6769fb59c8c99664c
core/src/main/scala/kafka/javaapi/consumer/ZookeeperConsumerConnector.scala
9baad34a9793e5067d11289ece2154ba87b388af
core/src/main/scala/kafka/tools/MirrorMaker.scala
77d951d13b8d8ad00af40257fe51623cc2caa61a
Diff: https://reviews.apache.org/r/25995/diff/
Testing
-------
Thanks,
Jiangjie Qin
