----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23702/#review65293 -----------------------------------------------------------
core/src/main/scala/kafka/common/GenerateBrokerIdException.scala <https://reviews.apache.org/r/23702/#comment108372> Can you fix the doc? core/src/main/scala/kafka/common/InconsistentBrokerIdException.scala <https://reviews.apache.org/r/23702/#comment108373> typo core/src/main/scala/kafka/common/InconsistentBrokerIdException.scala <https://reviews.apache.org/r/23702/#comment108379> Please include more constructors in both exception classes that allow passing in (message, cause), just message, just cause or nothing. core/src/main/scala/kafka/server/BrokerMetadataFileHandler.scala <https://reviews.apache.org/r/23702/#comment108382> version shouldn't be passed in. It should just live in this file. core/src/main/scala/kafka/server/BrokerMetadataFileHandler.scala <https://reviews.apache.org/r/23702/#comment108376> If this crashes before syncing the data, it might lead to a corrupted meta.properties file. We should probably write to a tmp file and atomically swap it in, similar to how we handle writes in other checkpoint files (eg. OffsetCheckpoint). Also, how about naming this BrokerMetadata? core/src/main/scala/kafka/server/KafkaServer.scala <https://reviews.apache.org/r/23702/#comment108377> Can you document the broker ids that don't match? Configured brokerId %d doesn't match stored brokerId %d in meta.properties core/src/main/scala/kafka/server/KafkaServer.scala <https://reviews.apache.org/r/23702/#comment108378> Can you use error("...", e)? core/src/main/scala/kafka/server/KafkaServer.scala <https://reviews.apache.org/r/23702/#comment108380> Please include the cause in the exception constructor. throw new GenerateBrokerIdException("Failed...", e); core/src/test/scala/unit/kafka/server/ServerGenerateBrokerIdTest.scala <https://reviews.apache.org/r/23702/#comment108381> offset checkpoint? - Neha Narkhede On Nov. 26, 2014, 4:29 a.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23702/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2014, 4:29 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1070 > https://issues.apache.org/jira/browse/KAFKA-1070 > > > Repository: kafka > > > Description > ------- > > KAFKA-1070. Auto-assign node id. > > > Diffs > ----- > > core/src/main/scala/kafka/common/GenerateBrokerIdException.scala > PRE-CREATION > core/src/main/scala/kafka/common/InconsistentBrokerIdException.scala > PRE-CREATION > core/src/main/scala/kafka/server/BrokerMetadataFileHandler.scala > PRE-CREATION > core/src/main/scala/kafka/server/KafkaConfig.scala > 6e26c5436feb4629d17f199011f3ebb674aa767f > core/src/main/scala/kafka/server/KafkaServer.scala > 1bf7d10cef23a77e716666eb16bf6d0e68bc4ebe > core/src/main/scala/kafka/utils/ZkUtils.scala > 56e3e88e0cc6d917b0ffd1254e173295c1c4aabd > core/src/test/scala/unit/kafka/server/ServerGenerateBrokerIdTest.scala > PRE-CREATION > core/src/test/scala/unit/kafka/utils/TestUtils.scala > 0da774d0ed015bdc0461b854e3540ee6e48d1838 > > Diff: https://reviews.apache.org/r/23702/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
