----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review65316 -----------------------------------------------------------
Overall, looks good. I do have a bit of a concern on having to maintain a separate set of broker compression codecs and I think that can be avoided. Looking forward to an updated patch. Please ping me as you did if you don't get a timely follow-up review. core/src/main/scala/kafka/log/Log.scala <https://reviews.apache.org/r/24704/#comment108432> Can you update the scaladoc? core/src/main/scala/kafka/log/LogConfig.scala <https://reviews.apache.org/r/24704/#comment108437> Can you make this doc a little more descriptive? E.g., how it relates to the producer compression type core/src/main/scala/kafka/message/BrokerCompression.scala <https://reviews.apache.org/r/24704/#comment108434> Can you think of a way to avoid having to maintain this distinctly from CompressionCodec.scala? E.g., one thought is to have a separate BrokerCompressionCodec sealed trait in that class; have all the existing codecs extend from both CompressionCodec and BrokerCompressionCodec and the new ProducerCompressionCodec only extend from BrokerCompressionCodec (or see if there is an altogether different better way) core/src/main/scala/kafka/server/KafkaConfig.scala <https://reviews.apache.org/r/24704/#comment108438> Similar note as above core/src/test/scala/unit/kafka/log/BrokerCompressionTest.scala <https://reviews.apache.org/r/24704/#comment108439> `...should produce " + readMessage(0).compressionCodec` - Joel Koshy On Dec. 16, 2014, 5:10 p.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24704/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2014, 5:10 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1499 > https://issues.apache.org/jira/browse/KAFKA-1499 > > > Repository: kafka > > > Description > ------- > > Support given for Broker-side compression > > > Diffs > ----- > > core/src/main/scala/kafka/log/Log.scala > 4fae2f0d339b256832baa62ca4995d10546716b4 > core/src/main/scala/kafka/log/LogConfig.scala > ca7a99e99f641b2694848b88bf4ae94657071d03 > core/src/main/scala/kafka/message/BrokerCompression.scala PRE-CREATION > core/src/main/scala/kafka/message/ByteBufferMessageSet.scala > 788c7864bc881b935975ab4a4e877b690e65f1f1 > core/src/main/scala/kafka/server/KafkaConfig.scala > 6e26c5436feb4629d17f199011f3ebb674aa767f > core/src/main/scala/kafka/server/KafkaServer.scala > 1bf7d10cef23a77e716666eb16bf6d0e68bc4ebe > core/src/test/scala/kafka/log/LogConfigTest.scala > 99b0df7b69c5e0a1b6251c54592c6ef63b1800fe > core/src/test/scala/unit/kafka/log/BrokerCompressionTest.scala PRE-CREATION > core/src/test/scala/unit/kafka/message/ByteBufferMessageSetTest.scala > 4e45d965bc423192ac704883ee75e9727006f89b > core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala > 2377abe4933e065d037828a214c3a87e1773a8ef > > Diff: https://reviews.apache.org/r/24704/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
