----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29210/#review66307 -----------------------------------------------------------
core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala <https://reviews.apache.org/r/29210/#comment109701> Gwen, I suggest adding this check (reading the checkpoint file and ensuring that the entries related to the deleted topic are gone) to the DeleteTopicTest. Rest of the patch looks good. We can check it in after this change - Neha Narkhede On Dec. 26, 2014, 9:58 p.m., Gwen Shapira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29210/ > ----------------------------------------------------------- > > (Updated Dec. 26, 2014, 9:58 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1819 > https://issues.apache.org/jira/browse/KAFKA-1819 > > > Repository: kafka > > > Description > ------- > > added locking > > > improved tests per Joel and Neha's suggestions > > > Diffs > ----- > > core/src/main/scala/kafka/log/LogCleaner.scala > f8fcb843c80eec3cf3c931df6bb472c019305253 > core/src/main/scala/kafka/log/LogCleanerManager.scala > bcfef77ed53f94017c06a884e4db14531774a0a2 > core/src/main/scala/kafka/log/LogManager.scala > 4ebaae00ca4b80bf15c7930bae2011d98bbec053 > core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala > 5bfa764638e92f217d0ff7108ec8f53193c22978 > > Diff: https://reviews.apache.org/r/29210/diff/ > > > Testing > ------- > > > Thanks, > > Gwen Shapira > >
