> On Jan. 8, 2015, 2:15 a.m., Neha Narkhede wrote:
> > Jun, have you had a chance to test the 0.8.1 client against the 0.8.2
> > server, as we had discussed earlier today?
Yes, it works as expected with the following test program built with the 0.8.1
branch.
package kafka
import kafka.utils.Logging
import kafka.consumer.SimpleConsumer
import kafka.common.{OffsetMetadataAndError, TopicAndPartition}
import kafka.api.{OffsetFetchRequest, OffsetCommitRequest}
object OffsetCommitMain extends Logging {
def main(args: Array[String]): Unit = {
val simpleConsumer = new SimpleConsumer("localhost", 9092, 1000000,
64*1024, "test-client")
val topic = "topic"
// Commit an offset
val topicAndPartition = TopicAndPartition(topic, 0)
val commitRequest = OffsetCommitRequest("test-group", Map(topicAndPartition
-> OffsetMetadataAndError(offset=42L)))
val commitResponse = simpleConsumer.commitOffsets(commitRequest)
System.out.println("OffsetCommitResponse: " + commitResponse.toString())
// Fetch it and verify
val fetchRequest = OffsetFetchRequest("test-group", Seq(topicAndPartition))
val fetchResponse = simpleConsumer.fetchOffsets(fetchRequest)
System.out.println("OffsetFetchResponse: " + fetchResponse.toString())
}
}
- Jun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29692/#review67149
-----------------------------------------------------------
On Jan. 8, 2015, 1:54 a.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29692/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2015, 1:54 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: kafka-1841
> https://issues.apache.org/jira/browse/kafka-1841
>
>
> Repository: kafka
>
>
> Description
> -------
>
> remove timestamp from version 0 protocol
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/common/protocol/Protocol.java
> 7517b879866fc5dad5f8d8ad30636da8bbe7784a
>
> clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitRequest.java
> 3ee5cbad55ce836fd04bb954dcf6ef2f9bc3288f
> core/src/main/scala/kafka/api/OffsetCommitRequest.scala
> 861a6cf11dc6b6431fcbbe9de00c74a122f204bd
> core/src/main/scala/kafka/common/OffsetMetadataAndError.scala
> 4cabffeacea09a49913505db19a96a55d58c0909
> core/src/main/scala/kafka/server/KafkaApis.scala
> 2f009920af37de3cf0a3eb131f2124f4e532c4e4
> core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala
> cd16ced5465d098be7a60498326b2a98c248f343
>
> Diff: https://reviews.apache.org/r/29692/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>
