> On Jan. 9, 2015, 11:07 a.m., Manikumar Reddy O wrote: > > kafka-patch-review.py, line 96 > > <https://reviews.apache.org/r/29756/diff/3/?file=814216#file814216line96> > > > > Did you tested the failure senario? I did not get error message. I > > think we will get exception only after invoking jira.issue(). > > Jaikiran Pai wrote: > I did test a failure case, yes. Gave an incorrect username and password > and that failed during login and did not proceed further. Here's the relevant > output (notice that I intentionally use JIRA user name "foo"): > > ` > > Configuring reviewboard url to https://reviews.apache.org > Updating your remote branches to pull the latest changes > Verifying JIRA connection configurations > JIRA user :foo > JIRA password : > Failed to login to the JIRA instance <class 'jira.exceptions.JIRAError'> > HTTP 401: " > > <html> > > <head> > <title>Unauthorized (401)</title> > > .... > ` > > Jaikiran Pai wrote: > By the way, if you are testing this, make sure you don't have a jira.ini > in its usual place. Else the (correct) credentials in there will be used as > usual and you won't be able to replicate a failing scenario. > > Manikumar Reddy O wrote: > Configuring reviewboard url to https://reviews.apache.org > Updating your remote branches to pull the latest changes > Verifying JIRA connection configurations > JIRA user :foo > JIRA password : > Creating diff against origin/0.8.2 and uploading patch to JIRA KAFKA-1723 > > > I am not getting exception, it going to next line of execution. It is > failing at jira.issue(). > > Version : jira-python 0.16 > > Jaikiran Pai wrote: > That's interesting. Let me see what might be different. > > Jaikiran Pai wrote: > Turns out the version of jira python that I had was 0.31 and behaved > differently. I downgraded to 0.16 and was able to replicate what you are > seeing. I've updated the patch to fix this and it should now correctly fail > if wrong JIRA credentials are specified, even before it attempts to publish > to reviewboard. > > Let me know if this now works for you too. Thanks for testing this! > > Manikumar Reddy O wrote: > Latest patch is working with jira-python 0.16. Some members may be using > older versions. We need to find correct API which works across all the > jira-python versions. (or) we need to add minimum version requirement.
Thank you Manikumar for testing and verifying. I'll see what can be done about the jira-python version issues. - Jaikiran ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29756/#review67414 ----------------------------------------------------------- On Jan. 9, 2015, 12:47 p.m., Jaikiran Pai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29756/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2015, 12:47 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1854 > https://issues.apache.org/jira/browse/KAFKA-1854 > > > Repository: kafka > > > Description > ------- > > KAFKA-1854 Allow JIRA username and password to be prompted in the absence of > a jira.ini file, during patch submission > > > Diffs > ----- > > kafka-patch-review.py b7f132f9d210b8648859ab8f9c89f30ec128ab38 > > Diff: https://reviews.apache.org/r/29756/diff/ > > > Testing > ------- > > > Thanks, > > Jaikiran Pai > >
