----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/#review67997 -----------------------------------------------------------
core/src/main/scala/kafka/client/ClientUtils.scala <https://reviews.apache.org/r/25944/#comment112130> ; not needed core/src/main/scala/kafka/client/ClientUtils.scala <https://reviews.apache.org/r/25944/#comment112131> This will blow up if getOffsetManagerChannel returns None. scala> None.get java.util.NoSuchElementException: None.get at scala.None$.get(Option.scala:322) ... 33 elided Maybe this method can return Option[BlockingChannel] instead of BlockingChannel? - Eric Olander On Jan. 14, 2015, 12:43 a.m., Mayuresh Gharat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25944/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2015, 12:43 a.m.) > > > Review request for kafka, Guozhang Wang, joel koshy, and Neha Narkhede. > > > Bugs: KAFKA-1013 > https://issues.apache.org/jira/browse/KAFKA-1013 > > > Repository: kafka > > > Description > ------- > > Reverted changes to ZookeeperConsumerConnector.scala > > > Combined the import/export offset tool in to a single tool. Refactored > OffsetClient > > > Deleted old Export/Import offsets tool > > > Added apache license > > > Added a default value for the constructor parameter > > > ConsumerOffsetChecker will print the OffsetManager and OffsetsTopicPartition > it is reading from > > > Resolving COnflicts for OffsetCommitTest.scala > > > Changed the description in comments regarding input parameters for the class > and added a check for groupId when th operation is import > > > Diffs > ----- > > core/src/main/scala/kafka/client/ClientUtils.scala > ebba87f0566684c796c26cb76c64b4640a5ccfde > core/src/main/scala/kafka/consumer/SimpleConsumer.scala > e53ee51638b930d8592ce9994ae2a617e7ef771c > core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala > 0ab0195dc9f66f407061d0fac2549bd6291e41ff > core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala > d1e7c434e77859d746b8dc68dd5d5a3740425e79 > core/src/main/scala/kafka/tools/ExportZkOffsets.scala > 4d051bc2db12f0e15aa6a3289abeb9dd25d373d2 > core/src/main/scala/kafka/tools/ImportExportOffsetTool.scala PRE-CREATION > core/src/main/scala/kafka/tools/ImportZkOffsets.scala > abe09721b13f71320510fd1a01c1917470450c6e > core/src/main/scala/kafka/tools/KafkaOffsetClient.scala PRE-CREATION > core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION > core/src/main/scala/kafka/tools/OffsetClientConfig.scala PRE-CREATION > core/src/main/scala/kafka/utils/Utils.scala > 738c1af9ef5de16fdf5130daab69757a14c48b5c > core/src/test/scala/other/kafka/TestOffsetManager.scala > 41f334d48897b3027ed54c58bbf4811487d3b191 > core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala > 4a3a5b264a021e55c39f4d7424ce04ee591503ef > > Diff: https://reviews.apache.org/r/25944/diff/ > > > Testing > ------- > > > Thanks, > > Mayuresh Gharat > >
