[ 
https://issues.apache.org/jira/browse/KAFKA-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280517#comment-14280517
 ] 

Guozhang Wang commented on KAFKA-1870:
--------------------------------------

Thanks for the findings Thomas.

However since the javaapi.OffsetCommitRequest is a public API class, adding the 
version_id into the construct directly will make backward incompatible changes: 
people using it without worrying the version id will break their apps when 
moving on to the new kafka vesion.

How about adding another constructor which takes the version id and leave the 
current one as-is?

Guozhang


> Cannot commit with simpleConsumer on Zookeeper only with Java API
> -----------------------------------------------------------------
>
>                 Key: KAFKA-1870
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1870
>             Project: Kafka
>          Issue Type: Bug
>          Components: consumer
>    Affects Versions: 0.8.2
>            Reporter: Thomas Vandevelde
>            Assignee: Neha Narkhede
>            Priority: Minor
>         Attachments: OffsetCommitRequest.diff
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> From Kafka 0.8.2, we need to pass version 0 in the OffsetCommitRequest if we 
> want to commit only on zookeeper.
> However the Java API doesnt allow to pass the version in parameter.
> Can you please add the version in the constructor of 
> kafka.javaapi.OffsetCommitRequest ?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to