[ 
https://issues.apache.org/jira/browse/KAFKA-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282051#comment-14282051
 ] 

Ashish Kumar Singh edited comment on KAFKA-1722 at 1/19/15 12:56 AM:
---------------------------------------------------------------------

Coverity does not support scala at all.
Coverall only has a sbt plugin for scala.

Using Coverall would have been really nice had their been a way to get scala 
coverage. Also I am not sure if coverall provides a way to manage multi module 
project with modules in different languages. As Kafka uses Gradle as a build 
tool and has most of its code in Scala, I do not think Coverall or Coverity 
will serve the purpose here.

For the scope of this JIRA, I believe having a way to generate coverage 
manually should suffice. Automating it should not be a big deal once we have 
this. Instrumentation and scanning will definitely take extra time, but I do 
not think its significant. I am not sure how review becomes hard if you get 
additional info on code coverage. If a piece of code is optimized and is tested 
code coverage can only increase.


was (Author: singhashish):
Coverity does not support scala at all.
Coverall only has a sbt plugin for scala.

Using Coverall would have been really nice had their been a way to get scala 
coverage. Also I am not sure if coverall provides a way to manage multi module 
project with projects in different languages. As Kafka uses Gradle as a build 
tool and has most of its code in Scala, I do not think Coverall or Coverity 
will serve the purpose here.

For the scope of this JIRA, I believe having a way to generate coverage 
manually should suffice. Automating it should not be a big deal once we have 
this. Instrumentation and scanning will definitely take extra time, but I do 
not think its significant. I am not sure how review becomes hard if you get 
additional info on code coverage. If a piece of code is optimized and is tested 
code coverage can only increase.

> static analysis code coverage for pci audit needs
> -------------------------------------------------
>
>                 Key: KAFKA-1722
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1722
>             Project: Kafka
>          Issue Type: Bug
>          Components: security
>            Reporter: Joe Stein
>            Assignee: Ashish Kumar Singh
>             Fix For: 0.9.0
>
>
> Code coverage is a measure used to describe the degree to which the source 
> code of a product is tested. A product with high code coverage has been more 
> thoroughly tested and has a lower chance of containing software bugs than a 
> product with low code coverage. Apart from PCI audit needs, increasing user 
> base of Kafka makes it important to increase code coverage of Kafka. 
> Something just can not be improved without being measured.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to