> On Jan. 19, 2015, 7:22 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/KafkaApis.scala, lines 197-201 > > <https://reviews.apache.org/r/30046/diff/1/?file=825225#file825225line197> > > > > Should we include the actual requiredAcks used in the request? > > Jun Rao wrote: > Also, we are not deprecating the pamameter. We are just deprecating some > values for this parameter. So, perhaps we can reword the logging message a > bit.
True, it is misleading. How about: Client %s (%s) sent a request with request.required.acks = %d. In Kafka 0.8.2 use of values other than -1, 0, 1 for this parameter is deprecated and will be removed in later releases. Please consult Kafka documentation for supported and recommended configuration. ? - Gwen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30046/#review68659 ----------------------------------------------------------- On Jan. 19, 2015, 6:58 p.m., Gwen Shapira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30046/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2015, 6:58 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1879 > https://issues.apache.org/jira/browse/KAFKA-1879 > > > Repository: kafka > > > Description > ------- > > fix string format > > > Diffs > ----- > > core/src/main/scala/kafka/server/KafkaApis.scala > 7def85254b1a17bfcaef96e49c3c98bc5a93c423 > > Diff: https://reviews.apache.org/r/30046/diff/ > > > Testing > ------- > > > Thanks, > > Gwen Shapira > >
