> On Jan. 27, 2015, 4:44 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala, line 69 > > <https://reviews.apache.org/r/30321/diff/1/?file=836389#file836389line69> > > > > Seems when yammer creates the mBeanName, it will use append ",scope=" > > before scope string, so I am wondering if it is OK to have "=" inside scope > > string? > > > > > > http://grepcode.com/file/repo1.maven.org/maven2/com.yammer.metrics/metrics-core/2.1.1/com/yammer/metrics/core/MetricName.java#MetricName.createMBeanName%28java.lang.String%2Cjava.lang.String%2Cjava.lang.String%2Cjava.lang.String%29
In our usage, we create the mbeanName ourselves and pass it into MetricName. So, we are not using the default mbeanName convention. - Jun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30321/#review69814 ----------------------------------------------------------- On Jan. 27, 2015, 4:16 p.m., Jun Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30321/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2015, 4:16 p.m.) > > > Review request for kafka. > > > Bugs: kafka-1902 > https://issues.apache.org/jira/browse/kafka-1902 > > > Repository: kafka > > > Description > ------- > > fix metric name by adding tags as scope > > > Diffs > ----- > > core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala > e9e49180f6de45f98e79374f519f6097b4fc8637 > > Diff: https://reviews.apache.org/r/30321/diff/ > > > Testing > ------- > > > Thanks, > > Jun Rao > >
