[ 
https://issues.apache.org/jira/browse/KAFKA-1902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294286#comment-14294286
 ] 

Jun Rao commented on KAFKA-1902:
--------------------------------

Is graphite the only reporter using scope? t seems that there are ganglia, cvs, 
and console reporters as well. If we use mytopic$with$dot.myclientId$with$dot, 
we lose the tag info for other reporters. Actually, even for Graphite reporter, 
preserving the tag names are probably useful. Otherwise, you are not sure 
exactly what you are navigating into (e.g., groupId, clientId and topic 
sometimes can be the same). Using 
topic.mytopic$with$dot.clientid.myclientId$with$dot would be better, but it may 
make parsing a bit harder for other types of reporters, if they make use of 
scope.

> fix MetricName so that Yammer reporter can work correctly
> ---------------------------------------------------------
>
>                 Key: KAFKA-1902
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1902
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>            Reporter: Jun Rao
>            Assignee: Jun Rao
>            Priority: Blocker
>             Fix For: 0.8.2
>
>         Attachments: kafka-1902.patch
>
>
> Currently, we create MetricName in the following format.
> group: "kafka.server"
> type: "BrokerTopicMetrics"
> name: "BytesInPerSec"
> scope: null
> mBeanName: 
> "kafka.server:type=BrokerTopicMetrics,name=BytesInPerSec,topic=test"
> However, Yammer metric reporter seems to only use the first four fields 
> group, type, name and scope during reporting.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to