----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30063/#review70508 -----------------------------------------------------------
core/src/main/scala/kafka/tools/MirrorMaker.scala <https://reviews.apache.org/r/30063/#comment115723> Similar to below comment, lines 220-226 are equivalent to: val customRebalanceListener = Option(options.valueOf(consumerRebalanceListenerOpt)).map { customRebalanceListenerClass => Utils.createObject[ConsumerRebalanceListener](customRebalanceListenerClass) } core/src/main/scala/kafka/tools/MirrorMaker.scala <https://reviews.apache.org/r/30063/#comment115722> Something to consider: mirrorMakerMessageHandler = Option(options.valueOf(mirrorMakerMessageHandlerOpt)).map { mirrorMakerMessageHandlerClass => Utils.createObject[MirrorMakerMessageHandler](mirrorMakerMessageHandlerClass) }.getOrElse(new defaultMirrorMakerMessageHandler) - Eric Olander On Jan. 31, 2015, 2:25 a.m., Jiangjie Qin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30063/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2015, 2:25 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1840 > https://issues.apache.org/jira/browse/KAFKA-1840 > > > Repository: kafka > > > Description > ------- > > Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into > KAFKA-1840 > > > Addressed Joel's comments > > > Allow message handler to specify partitions for produce > > > Diffs > ----- > > core/src/main/scala/kafka/tools/MirrorMaker.scala > 81ae205ef7b2050d0152f29f8da7dd91b17b8b00 > > Diff: https://reviews.apache.org/r/30063/diff/ > > > Testing > ------- > > > Thanks, > > Jiangjie Qin > >
