> On Jan. 26, 2015, 1:28 a.m., Neha Narkhede wrote: > > core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala, line 235 > > <https://reviews.apache.org/r/30196/diff/1/?file=831148#file831148line235> > > > > what is the purpose of this sleep? > > Aditya Auradkar wrote: > I wanted to make sure the SimpleConsumer was making a request to the > broker when I interrupted. I can reduce the sleep time to 100ms if that helps.
Neha, Is this the right place to add such a test case. I've added it to PrimitiveApiTest but this isn't really testing an API.. merely testing SimpleConsumer behavior. - Aditya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30196/#review69579 ----------------------------------------------------------- On Feb. 2, 2015, 9:57 p.m., Aditya Auradkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30196/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2015, 9:57 p.m.) > > > Review request for kafka and Joel Koshy. > > > Bugs: KAFKA-1886 > https://issues.apache.org/jira/browse/KAFKA-1886 > > > Repository: kafka > > > Description > ------- > > Fixing KAFKA-1886. SimpleConsumer should not swallow > ClosedByInterruptException > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/SimpleConsumer.scala > cbef84ac76e62768981f74e71d451f2bda995275 > core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala > aeb7a19acaefabcc161c2ee6144a56d9a8999a81 > > Diff: https://reviews.apache.org/r/30196/diff/ > > > Testing > ------- > > Added an integration test to PrimitiveAPITest.scala. > > > Thanks, > > Aditya Auradkar > >
