After checkstyle is tuned, maybe we can add that as part of pre-commit
testing, KAFKA-1856.

On Tue, Feb 3, 2015 at 8:59 PM, Jay Kreps <[email protected]> wrote:

> I just committed the checkstyle patch (KAFKA-1915). This will do the
> checkstyle evaluation when you run the unit tests and error on style
> inconsistencies. It can be hard to say which checks are more trouble than
> they are worth or are two pedantic. Let's give this a try and see if it is
> annoying or helpful. If annoying let's tune our config to try to fix it.
>
> The hope is this will help keep things pretty as we continue to expand the
> set of contributors.
>
> -Jay
>



-- 

Regards,
Ashish
  • checkstyle Jay Kreps
    • Re: checkstyle Ashish Singh

Reply via email to