-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27391/
-----------------------------------------------------------

(Updated Feb. 6, 2015, 7:01 p.m.)


Review request for kafka.


Bugs: KAFKA-1634
    https://issues.apache.org/jira/browse/KAFKA-1634


Repository: kafka


Description (updated)
-------

Incorporated Joel's comments


Diffs (updated)
-----

  clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java 
09a6f11163ecb1e733c604ade04646e83bbc0c85 
  clients/src/main/java/org/apache/kafka/common/protocol/Protocol.java 
101f382170ad6740b3f8ff2d27b93a64874a857f 
  clients/src/main/java/org/apache/kafka/common/protocol/types/Struct.java 
ff89f0e37d5fa787b0218eff86d169aaeae2107b 
  
clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitRequest.java 
94e9d376235b3288836807d8e8d2547b3743aad5 
  
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java 
13237fd72da5448a3d596b882fef141f336f827d 
  core/src/main/scala/kafka/api/OffsetCommitRequest.scala 
050615c72efe7dbaa4634f53943bd73273d20ffb 
  core/src/main/scala/kafka/api/OffsetFetchRequest.scala 
c7604b9cdeb8f46507f04ed7d35fcb3d5f150713 
  core/src/main/scala/kafka/common/OffsetMetadataAndError.scala 
4cabffeacea09a49913505db19a96a55d58c0909 
  core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 
5487259751ebe19f137948249aa1fd2637d2deb4 
  core/src/main/scala/kafka/server/KafkaApis.scala 
f2b027bf944e735fd52cc282690ec1b8395f9290 
  core/src/main/scala/kafka/server/KafkaConfig.scala 
6d74983472249eac808d361344c58cc2858ec971 
  core/src/main/scala/kafka/server/KafkaServer.scala 
89200da30a04943f0b9befe84ab17e62b747c8c4 
  core/src/main/scala/kafka/server/OffsetManager.scala 
0bdd42fea931cddd072c0fff765b10526db6840a 
  core/src/main/scala/kafka/server/ReplicaManager.scala 
fb948b9ab28c516e81dab14dcbe211dcd99842b6 
  core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala 
a1f72f8c2042ff2a43af503b2e06f84706dad9db 
  core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 
5b93239cdc26b5be7696f4e7863adb9fbe5f0ed5 
  core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala 
ba1e48e4300c9fb32e36e7266cb05294f2a481e5 

Diff: https://reviews.apache.org/r/27391/diff/


Testing
-------


Thanks,

Guozhang Wang

Reply via email to