----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30403/#review71557 -----------------------------------------------------------
config/server.properties <https://reviews.apache.org/r/30403/#comment117312> Why leave the value here to point at /tmp/kafka-logs? The way I see is that we default the log directory to data/ in the kafka installation directory and possibly encourage storing kafka data under var/ if it must be overridden for production, by changing this commented out value to /var/kafka-logs? core/src/main/scala/kafka/server/KafkaConfig.scala <https://reviews.apache.org/r/30403/#comment117313> If KAFKA_HOME is not set (since somehow they are starting the kafka server using different scripts), then we should just point the log directory to the value of log.dirs and not force a default to /tmp. - Neha Narkhede On Jan. 29, 2015, 6:24 a.m., Jaikiran Pai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30403/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2015, 6:24 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1906 > https://issues.apache.org/jira/browse/KAFKA-1906 > > > Repository: kafka > > > Description > ------- > > KAFKA-1906 Default the Kafka data log directory to > $KAFKA_HOME/data/kafka-logs directory, where KAFKA_HOME is the Kafka > installation directory > > > Diffs > ----- > > bin/kafka-run-class.sh 881f578a8f5c796fe23415b978c1ad35869af76e > bin/windows/kafka-run-class.bat 9df3d2b45236b4f06d55a89c84afcf0ab9f5d0f2 > config/server.properties 1614260b71a658b405bb24157c8f12b1f1031aa5 > core/src/main/scala/kafka/server/KafkaConfig.scala > 6d74983472249eac808d361344c58cc2858ec971 > core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala > 82dce80d553957d8b5776a9e140c346d4e07f766 > > Diff: https://reviews.apache.org/r/30403/diff/ > > > Testing > ------- > > The change here involves updating the Kafka scripts (for Windows and * nix) > to infer and setup KAFKA_HOME environment variable. This value is then used > by the KafkaConfig to decide what path to default to for the Kafka data logs, > in the absence of any explicitly set log.dirs (or log.dir) properties. > > Care has been taken to ensure that other mechanism which might presently be > bypassing the Kafka scripts, will still continue to function, since in the > absence of KAFKA_HOME environment property value, we fall back to > /tmp/kafka-logs (the present default) as the default data log directory > > Existing tests have been run to ensure that this change maintains backward > compatibility (i.e. doesn't fail when KAFKA_HOME isn't available/set) and 2 > new test methods have been added to the KafkaConfigTest to ensure that this > change works. > > Although the change has been made to both .sh and .bat files, to support > this, I haven't actually tested this change on a Windows OS and would > appreciate if someone can test this there and let me know if they run into > any issues. > > > Thanks, > > Jaikiran Pai > >
