[
https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317781#comment-14317781
]
Honghai Chen commented on KAFKA-1947:
-------------------------------------
The fix is quite directly:
When has replicaAssignment, the command should only be createTopic or alterTopic
When the command is create topic, and replicaAssignment appear, there should
no partitions and replica number.
The command told me board is ok, but actually no. But patch uploaded.
D:\C\Kafka_Update>kafka-patch-review_.py -b origin/trunk -j KAFKA-1947
Configuring reviewboard url to https://reviews.apache.org
Updating your remote branches to pull the latest changes
Creating diff against origin/trunk and uploading patch to JIRA KAFKA-1947
Created a new reviewboard
D:\C\Kafka_Update>
> can't explicitly set replica-assignment when add partitions
> -----------------------------------------------------------
>
> Key: KAFKA-1947
> URL: https://issues.apache.org/jira/browse/KAFKA-1947
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8.1.1
> Environment: Windows
> Reporter: Honghai Chen
> Attachments: KAFKA-1947.patch
>
>
> When create topic, the replicaAssignmentOpt should not appear with partitions.
> But when add partitions, they should can appear together, from the code
> below, you can see when alter topic, and has partitions in arguments, it try
> get "replica-assignment"
> https://git1-us-west.apache.org/repos/asf?p=kafka.git;a=blob;f=core/src/main/scala/kafka/admin/TopicCommand.scala;h=285c0333ff43543d3e46444c1cd9374bb883bb59;hb=HEAD#l114
>
> The root cause is below code:
> CommandLineUtils.checkInvalidArgs(parser, options, replicaAssignmentOpt,
> 305 allTopicLevelOpts -- Set(alterOpt, createOpt) + partitionsOpt +
> replicationFactorOpt)
> https://git1-us-west.apache.org/repos/asf?p=kafka.git;a=blob;f=core/src/main/scala/kafka/admin/TopicCommand.scala;h=285c0333ff43543d3e46444c1cd9374bb883bb59;hb=HEAD#l304
> Related:
> https://issues.apache.org/jira/browse/KAFKA-1052
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
