[
https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317835#comment-14317835
]
Honghai Chen edited comment on KAFKA-1947 at 2/12/15 8:57 AM:
--------------------------------------------------------------
Submit review ...
https://reviews.apache.org/r/30919/diff/
Please help check
was (Author: waldenchen):
Submit review ...
https://reviews.apache.org/r/30919/
https://reviews.apache.org/r/30919/diff/
> can't explicitly set replica-assignment when add partitions
> -----------------------------------------------------------
>
> Key: KAFKA-1947
> URL: https://issues.apache.org/jira/browse/KAFKA-1947
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8.1.1
> Environment: Windows
> Reporter: Honghai Chen
> Attachments: KAFKA-1947.patch
>
>
> When create topic, the replicaAssignmentOpt should not appear with partitions.
> But when add partitions, they should can appear together, from the code
> below, you can see when alter topic, and has partitions in arguments, it try
> get "replica-assignment"
> https://git1-us-west.apache.org/repos/asf?p=kafka.git;a=blob;f=core/src/main/scala/kafka/admin/TopicCommand.scala;h=285c0333ff43543d3e46444c1cd9374bb883bb59;hb=HEAD#l114
>
> The root cause is below code:
> CommandLineUtils.checkInvalidArgs(parser, options, replicaAssignmentOpt,
> 305 allTopicLevelOpts -- Set(alterOpt, createOpt) + partitionsOpt +
> replicationFactorOpt)
> https://git1-us-west.apache.org/repos/asf?p=kafka.git;a=blob;f=core/src/main/scala/kafka/admin/TopicCommand.scala;h=285c0333ff43543d3e46444c1cd9374bb883bb59;hb=HEAD#l304
> Related:
> https://issues.apache.org/jira/browse/KAFKA-1052
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
