> On Feb. 16, 2015, 6:22 p.m., Gwen Shapira wrote: > > The rename does make things a bit clearer, so I don't object to committing > > it. > > But the test does not override "group" in superclas Thread. Thread.group is > > a private variable, so it cannot be overriden (and the classes that inherit > > from it can't use it) so there's no conflict here.
Thanks Gwen, completely agreed. What puzzled me is that the compile error. I do not know how to explain that. I have uploaded the screen shot of the error against the jira issue, I wonder if you can give a bit of opinion on that? Here is the link https://issues.apache.org/jira/secure/attachment/12699149/compileError.png - Tong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31088/#review72637 ----------------------------------------------------------- On Feb. 16, 2015, 4:37 p.m., Tong Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31088/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2015, 4:37 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1959 > https://issues.apache.org/jira/browse/KAFKA-1959 > > > Repository: kafka > > > Description > ------- > > The original code clearly wants to define a string but override the > ThreadGroup of > the super class member. The patchset will rename the private variable to be > group_id > as it intended. > > > Diffs > ----- > > core/src/test/scala/other/kafka/TestOffsetManager.scala > 41f334d48897b3027ed54c58bbf4811487d3b191 > > Diff: https://reviews.apache.org/r/31088/diff/ > > > Testing > ------- > > > Thanks, > > Tong Li > >
