Joel, thanks so much for merging the two sets.
Tong Sent from my iPhone > On Feb 18, 2015, at 2:55 AM, Joel Koshy (JIRA) <j...@apache.org> wrote: > > [ https://issues.apache.org/jira/browse/KAFKA-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] > > Joel Koshy resolved KAFKA-1959. > ------------------------------- > Resolution: Fixed > Assignee: Tong Li > > Thanks for the patch - committed to trunk. > > > Class CommitThread overwrite group of Thread class causing compile errors > > ------------------------------------------------------------------------- > > > > Key: KAFKA-1959 > > URL: https://issues.apache.org/jira/browse/KAFKA-1959 > > Project: Kafka > > Issue Type: Bug > > Components: core > > Environment: scala 2.10.4 > > Reporter: Tong Li > > Assignee: Tong Li > > Labels: newbie > > Attachments: KAFKA-1959.patch, compileError.png > > > > > > class CommitThread(id: Int, partitionCount: Int, commitIntervalMs: Long, zkClient: ZkClient) > > extends ShutdownableThread("commit-thread") > > with KafkaMetricsGroup { > > private val group = "group-" + id > > group overwrite class Thread group member, causing the following compile error: > > overriding variable group in class Thread of type ThreadGroup; value group has weaker access privileges; it should not be private > > > > -- > This message was sent by Atlassian JIRA > (v6.3.4#6332) >
