> On Feb. 18, 2015, 12:06 a.m., Mayuresh Gharat wrote: > > core/src/main/scala/kafka/tools/ContinuousValidationTest.java, line 207 > > <https://reviews.apache.org/r/30809/diff/1/?file=859055#file859055line207> > > > > This might end up in infinite loop if something goes wrong with > > cluster, right? > > Should we have a maximum numnber of retries? > > What do you think?
This will not be an issue since for timed runs we will interrupt the thread anyway after a fixed time. This is the mode which is being used in the upgrade test. > On Feb. 18, 2015, 12:06 a.m., Mayuresh Gharat wrote: > > core/src/main/scala/kafka/tools/ContinuousValidationTest.java, line 424 > > <https://reviews.apache.org/r/30809/diff/1/?file=859055#file859055line424> > > > > Are you assuming that first argument will be some key? If you take a look at the script I am expecting alternate parameters like -timedRun <> -timeToSpawn <> Key is essentially the parameter name. > On Feb. 18, 2015, 12:06 a.m., Mayuresh Gharat wrote: > > core/src/main/scala/kafka/tools/ContinuousValidationTest.java, line 474 > > <https://reviews.apache.org/r/30809/diff/1/?file=859055#file859055line474> > > > > what do you mean by rebuild state later? What I meant was that between two runs for the rolling upgrade test we will not re-use any state from zookeeper or the brokers so I do not need to worry about clean shutdown. > On Feb. 18, 2015, 12:06 a.m., Mayuresh Gharat wrote: > > core/src/main/scala/kafka/tools/ContinuousValidationTest.java, line 77 > > <https://reviews.apache.org/r/30809/diff/1/?file=859055#file859055line77> > > > > Why we need a flip? The flip is needed to reset the get pointer in byte buffer to beginning of the byte buffer else we will get underflow exception. - Abhishek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30809/#review72786 ----------------------------------------------------------- On Feb. 18, 2015, 1:59 a.m., Abhishek Nigam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30809/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2015, 1:59 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1888 > https://issues.apache.org/jira/browse/KAFKA-1888 > > > Repository: kafka > > > Description > ------- > > patch for KAFKA-1888 > > > Diffs > ----- > > build.gradle 0f0fe60a74542efa91a0e727146e896edcaa38af > core/src/main/scala/kafka/tools/ContinuousValidationTest.java PRE-CREATION > system_test/broker_upgrade/bin/kafka-run-class.sh PRE-CREATION > system_test/broker_upgrade/bin/test.sh PRE-CREATION > system_test/broker_upgrade/configs/server1.properties PRE-CREATION > system_test/broker_upgrade/configs/server2.properties PRE-CREATION > system_test/broker_upgrade/configs/zookeeper_source.properties PRE-CREATION > > Diff: https://reviews.apache.org/r/30809/diff/ > > > Testing > ------- > > Scripted it to run 20 times without any failures. > Command-line: broker-upgrade/bin/test.sh <dir1> <dir2> > > > Thanks, > > Abhishek Nigam > >
