> On Feb. 19, 2015, 1:32 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/javaapi/OffsetFetchRequest.scala, line 47 > > <https://reviews.apache.org/r/31169/diff/2/?file=868598#file868598line47> > > > > Should we remove the comment?
Thanks - yes will do that on check-in if everything else looks good to you. - Joel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31169/#review73057 ----------------------------------------------------------- On Feb. 19, 2015, 1:30 a.m., Joel Koshy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31169/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2015, 1:30 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1729 > https://issues.apache.org/jira/browse/KAFKA-1729 > > > Repository: kafka > > > Description > ------- > > Allow constructing explicitly versioned offset fetch request in javaapi > > > Diffs > ----- > > core/src/main/scala/kafka/javaapi/OffsetFetchRequest.scala > 1c25aa3332f9e4f0222db715b524d9179b5306cf > > Diff: https://reviews.apache.org/r/31169/diff/ > > > Testing > ------- > > > Thanks, > > Joel Koshy > >
