> On Feb. 8, 2015, 7:04 p.m., Ewen Cheslack-Postava wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java, > > line 352 > > <https://reviews.apache.org/r/30763/diff/1/?file=853737#file853737line352> > > > > This isn't properly reset in the case of InterruptionExceptions. This > > should be in a finally block.
Yeah this is a good point. We have somewhat ignored InterruptedException. I don't like to throw it from public methods because I think it then forces the user to deal with it even if they aren't going to call interrupt which is really annoying. So how about this, I'll add an InterruptException which can be our unchecked version of InterruptedException. We can reset the interrupt flag and throw that (to differentiate from the generic KafkaException). - Jay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30763/#review71573 ----------------------------------------------------------- On Feb. 7, 2015, 8:59 p.m., Jay Kreps wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30763/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2015, 8:59 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1865 > https://issues.apache.org/jira/browse/KAFKA-1865 > > > Repository: kafka > > > Description > ------- > > KAFKA-1865 Add a flush() method to the producer. > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java > 1fd6917c8a5131254c740abad7f7228a47e3628c > clients/src/main/java/org/apache/kafka/clients/producer/MockProducer.java > 84530f2b948f9abd74203db48707e490dd9c81a5 > clients/src/main/java/org/apache/kafka/clients/producer/Producer.java > 17fe541588d462c68c33f6209717cc4015e9b62f > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java > ecfe2144d778a5d9b614df5278b9f0a15637f10b > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordBatch.java > dd0af8aee98abed5d4a0dc50989e37888bb353fe > > clients/src/test/java/org/apache/kafka/clients/producer/MockProducerTest.java > 75513b0bdd439329c5771d87436ef83fda853bfb > > clients/src/test/java/org/apache/kafka/clients/producer/RecordAccumulatorTest.java > 83338633717cfa4ef7cf2a590b5aa6b9c8cb1dd2 > core/src/test/scala/integration/kafka/api/ProducerSendTest.scala > b15237b76def3b234924280fa3fdb25dbb0cc0dc > core/src/test/scala/unit/kafka/utils/TestUtils.scala > 54755e8dd3f23ced313067566cd4ea867f8a496e > > Diff: https://reviews.apache.org/r/30763/diff/ > > > Testing > ------- > > > Thanks, > > Jay Kreps > >
